Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining dependencies on Moment.js #7716

Merged

Conversation

stopfstedt
Copy link
Member

this finally frees us of any remaining dependencies on Moment.js.

fixes ilios/ilios#5193

stefan@nichtsnutz: ~/dev/projects/frontend on moment-to-luxon-conversion-the-rest
$ grep -ri 'moment' packages | egrep -v '(node_modules|dist)'
packages/ilios-common/translations/en-us.yaml:  waitSaving: saving... one moment...
packages/ilios-common/translations/es.yaml:  waitSaving: Salvando... un momento...
packages/ilios-common/translations/fr.yaml:  waitSaving: Travaille dessus... un moment...
packages/frontend/app/components/reports/subject/new/academic-year.js:    yield timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/program.js:    await timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/term.js:    await timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/instructor-group.js:    await timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/session-type.js:    await timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/competency.js:    await timeout(1); //wait a moment so we can render before setting
packages/frontend/app/components/reports/subject/new/program-year.js:    await timeout(1); //wait a moment so we can render before setting
packages/test-app/tests/integration/components/wait-saving-test.js:    assert.dom(this.element).hasText('saving... one moment...');

@stopfstedt stopfstedt marked this pull request as ready for review March 14, 2024 21:32
@stopfstedt stopfstedt requested a review from jrjohnson as a code owner March 14, 2024 21:32
@stopfstedt stopfstedt requested a review from dartajax March 14, 2024 21:32
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as switching languages is concerned, the behavior is consistent with demo so ... looks good to me in that regard for sure.

@stopfstedt stopfstedt changed the title Moment to luxon conversion the rest Remove remaining dependencies on Moment.js Mar 14, 2024
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💯 woot! 😀 😂

@jrjohnson jrjohnson merged commit 84d5555 into ilios:master Mar 15, 2024
26 checks passed
@stopfstedt stopfstedt deleted the moment-to-luxon-conversion-the-rest branch March 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove our dependency on moment.js altogether
3 participants