Refactor UserProfileCalendar component #7737
Merged
+32
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The impetus of this was to fix the component's data loading on Sunday night in en-us where the data from the previous week would get loaded instead. I replaced the loading modifier with a tracked async getter and linked this up to the localeDays service. I also replaced the loader with the built in one that is now in the weekly calendar.
stopfstedt
reviewed
Mar 25, 2024
|
|
||
| load = dropTask(async () => { | ||
| //luxon weeks always stort on Monday to we have to adjust for that |
There was a problem hiding this comment.
Didn't really need to git blame to know who that line belonged to 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus of this was to fix the component's data loading on Sunday night in en-us where the data from the previous week would get loaded instead. I replaced the loading modifier with a tracked async getter and linked this up to the localeDays service.
I also replaced the loader with the built in one that is now in the weekly calendar.