Check to make sure service workers is enabled #7739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of our supported browsers support workers, however in comes cases (like FF private) the worker isn't enabled. This check ensures that the worker exists and is enabled before we try and check it.
stopfstedt
approved these changes
Mar 26, 2024
| if ( | ||
| isTesting() || | ||
| config.disableServiceWorker || | ||
| !('serviceWorker' in navigator) || |
There was a problem hiding this comment.
in - not so scary now, eh?! 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our supported browsers support workers, however in comes cases (like FF private) the worker isn't enabled. This check ensures that the worker exists and is enabled before we try and check it.
Fixes ilios/ilios#4761