Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace permission-checker Resource with TrackedAsyncData equivalent. #7752

Merged
merged 4 commits into from
Apr 5, 2024
Merged

replace permission-checker Resource with TrackedAsyncData equivalent. #7752

merged 4 commits into from
Apr 5, 2024

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt force-pushed the replace_permission_checker_resource branch 11 times, most recently from 6778c44 to 5f98c35 Compare April 4, 2024 21:17
@stopfstedt stopfstedt marked this pull request as ready for review April 4, 2024 21:30
@stopfstedt stopfstedt requested a review from jrjohnson as a code owner April 4, 2024 21:30
jrjohnson
jrjohnson requested changes Apr 5, 2024
View reviewed changes
packages/frontend/app/components/courses/root.js Outdated Show resolved Hide resolved
packages/frontend/app/components/instructor-groups/root.js Outdated Show resolved Hide resolved
packages/frontend/app/components/learner-group/list-item.js Outdated Show resolved Hide resolved
packages/frontend/app/components/learner-groups/root.js Outdated Show resolved Hide resolved
packages/frontend/app/components/programs/root.js Outdated Show resolved Hide resolved
packages/ilios-common/.lint-todo Outdated Show resolved Hide resolved
@stopfstedt stopfstedt force-pushed the replace_permission_checker_resource branch from 4f99b70 to e1094b0 Compare April 5, 2024 17:10
@stopfstedt stopfstedt requested a review from jrjohnson April 5, 2024 17:15
jrjohnson
jrjohnson approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dartajax dartajax merged commit 8d0e947 into ilios:master Apr 5, 2024
26 checks passed
@stopfstedt stopfstedt deleted the replace_permission_checker_resource branch December 10, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees

@dartajax dartajax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stopfstedt @jrjohnson @dartajax