Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ignored lint rule with todo #7753

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jrjohnson
Copy link
Member

Instead of disabling the no-at-ember-render-modifiers linting rule I've added todo for each existing case. This will give us a runway for fixing this issue and ensure we don't create any new cases.

Instead of disabling the no-at-ember-render-modifiers linting rule I've
added todo for each existing case. This will give us a runway for fixing
this issue and ensure we don't create any new cases.
@jrjohnson jrjohnson marked this pull request as ready for review April 3, 2024 23:44
@jrjohnson jrjohnson requested a review from stopfstedt as a code owner April 3, 2024 23:44
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks!

@stopfstedt stopfstedt merged commit 2aa99ba into ilios:master Apr 4, 2024
26 checks passed
@jrjohnson jrjohnson deleted the todo-render-modifiers branch April 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants