Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v prefix to sentry errors #7758

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jrjohnson
Copy link
Member

Our releases are prefixed with this in the tag and in the data we're sending to sentry describing the build. However we pull the info from the package.json in frontend where npm asks for the version without the prefix. We need to add it to the sentry errors to ensure our error reports can line up with released versions and their source maps and commit data.

Our releases are prefixed with this in the tag and in the data we're
sending to sentry describing the build. However we pull the info from
the package.json in frontend where npm asks for the version without the
prefix. We need to add it to the sentry errors to ensure our error
reports can line up with released versions and their source maps and
commit data.
@jrjohnson jrjohnson force-pushed the sentry-maps-again branch from 733819f to f39284f Compare April 5, 2024 15:37
@jrjohnson jrjohnson marked this pull request as ready for review April 5, 2024 16:13
@jrjohnson jrjohnson requested a review from stopfstedt as a code owner April 5, 2024 16:13
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so fiddly. approved.

@dartajax dartajax merged commit 811384c into ilios:master Apr 5, 2024
26 checks passed
@jrjohnson jrjohnson deleted the sentry-maps-again branch April 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants