Fix staging deploy runs #7802
Merged
Fix staging deploy runs #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the GITHUB_TOKEN to create an automerge will not trigger other github actions so our staging deploys aren't running when these get merged. Github recommends we use a PAT, and we've got one ready made from Zorgbort. This was Zorgbort is responsible for the merge and github is happy to go forth and trigger more actions.
jrjohnson
requested review from
michaelchadwick
and removed request for
stopfstedt
|
@jrjohnson So...who or what is "Zorgbort"? |
|
Excellent question! Zorgbort is the name of our chat bot that handles a lot of tasks and connects to a GitHub bot user for automation. |
|
When you review a PR, do you usually add any kind of labels? |
michaelchadwick
approved these changes
Apr 29, 2024
|
Regardless, @dartajax this PR has been approved and assigned to you (even though it probably could've just been merged by me, I figured it was good form). |
|
No labels, just an approval and then assign it or merge it. In this case you should feel free to merge as it's infrastructure and not user facing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the GITHUB_TOKEN to create an automerge will not trigger other github actions so our staging deploys aren't running when these get merged. Github recommends we use a PAT, and we've got one ready made from Zorgbort. This was Zorgbort is responsible for the merge and github is happy to go forth and trigger more actions.