Learning material file uploads now uploading and persisting through refresh #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great. |
thecoolestguy
force-pushed
the
431_lm_file_uploader
branch
2 times, most recently
from
fb6b8e8 to
4b0078f
Compare
… address php side, refs #431
… not actually needed
thecoolestguy
force-pushed
the
431_lm_file_uploader
branch
from
4b0078f to
680b79c
Compare
| @@ -298,6 +298,20 @@ export default function() { | |||
| return new Mirage.Response(400, {}, {errors: errors}); | |||
| }); | |||
|
|
|||
| this.post('/upload', function(db, request) { | |||
There was a problem hiding this comment.
This is where your test are failing. Signature should be
this.post('/upload', function() {Since request and db arguments are not used in the function.
jrjohnson
added a commit
that referenced
this pull request
Aug 7, 2015
Learning material file uploads now uploading and persisting through refresh
|
Changes Unknown when pulling ac6b85c on thecoolestguy:431_lm_file_uploader into ** on ilios:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #431