fix missing session timed release information #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
michaelchadwick
changed the title
jrjohnson
requested changes
Sep 12, 2024
jrjohnson
previously approved these changes
Sep 13, 2024
…pancy across site
michaelchadwick
force-pushed
the
frontend-5697-show-timed-ilm-fix
branch
from
aa47a13 to
5cbb455
Compare
dartajax
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#5697
Looks like
.fromJSDate()is looking for a JSDateobject, not a string, so I converted it. There are severalDateTimefunctions that could conceivably do the job, too, but this way kept tests passing, so it seemed the most prudent.