Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Array Prototypes #8143

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

jrjohnson
Copy link
Member

We don't need this anymore, the issue we were originally hitting was caused by upstream ember issues as well as some of the helpers from ember-composable-helpers (which we have since added directly here). We can go ahead and disable these and silence the deprecation warnings being emitted since updating ember.

We don't need this anymore, the issue we were originally hitting was
caused by upstream ember issues as well as some of the helpers from
ember-composable-helpers (which we have since added directly here). We
can go ahead and disable these and silence the deprecation warnings
being emitted since updating ember.
@jrjohnson jrjohnson marked this pull request as ready for review September 19, 2024 04:38
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

@stopfstedt stopfstedt self-assigned this Sep 19, 2024
@stopfstedt stopfstedt merged commit 9970248 into ilios:master Sep 19, 2024
40 of 41 checks passed
@jrjohnson jrjohnson deleted the array-prototypes branch September 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants