Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UserMenu component render modifier #8179

Merged

Conversation

michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Oct 4, 2024

Refs ilios/ilios#5374

Also fixed a bug where if you keyboard tabbed over to the user menu and pressed UpArrow, it would throw a console error: Uncaught TypeError: Cannot read properties of undefined (reading 'previousElementSibling')

@michaelchadwick
Copy link
Contributor Author

Added keyboard navigation testing to UserMenu component. Needed to add a slight delay in both the component and integration test to properly set focus and test for it.

Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be another check on item?

packages/frontend/app/components/user-menu.js Outdated Show resolved Hide resolved
Co-authored-by: Jon Johnson <[email protected]>
@michaelchadwick michaelchadwick added the run ui tests Run the expensive UI tests label Oct 8, 2024
@dartajax dartajax merged commit a5d8983 into ilios:master Oct 8, 2024
43 checks passed
Copy link

sentry-io bot commented Oct 17, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'focus') route:dashboard.calendar View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants