Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Autoupdate Check from Failure #8206

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Oct 31, 2024

I hate the big red x on this, I think this will help.

Screenshot 2024-11-01 at 9 12 51 AM

This only shows up on dependabot PRs like #8197

[Edit: ST 11/01/2024]: for reference: https://stackoverflow.com/questions/73427676/what-is-difference-between-pnpm-create-pnpx-dlx

@jrjohnson jrjohnson marked this pull request as ready for review November 1, 2024 04:46
@jrjohnson jrjohnson added the run ui tests Run the expensive UI tests label Nov 1, 2024
@michaelchadwick
Copy link
Contributor

I'm not sure what this fixes/changes. Can you provide a screenshot before (and maybe after)? Sorry, but I'm not as familiar with all the CI stuff :)

@jrjohnson
Copy link
Member Author

Before screen shot added. I can't do an after screenshot because this check only runs on dependabot PRs, we'll have to see if I flubbed it after merging.

I hate the big red x on this, I think this will help.
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about dlx.

LGTM

@dartajax dartajax merged commit 6106fe1 into ilios:master Nov 1, 2024
37 checks passed
@jrjohnson jrjohnson deleted the no-x-till-brooklyn branch November 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants