synchronize Course/Session objective description/parentObjectives FadeText status

[michaelchadwick]

Fixes ilios/ilios#5645

Whew, this was a long time coming for me. Basically, be it Courses or Sessions, their objectives (and their Description and Parent Objective columns) now synchronize in individual rows, so that if you expand one column, the other column expands, as well (and in the opposite direction, too). Had to learn how to send functions from parent objectives down to child objectives and all that, so fun! ObjectiveSortManager has to short-circuit this by having its own function that overrides the one sent by ObjectiveListItem.

[jrjohnson]

Behavior looks great to me! There are some possibly artistic choices in what expands all. Clicking the expander catches everything, but clicking to edit a title or parents doesn't. I played with it for a while and I think I like this, but wanted to call it out for further testing by @dartajax.

[michaelchadwick]

@dartajax @jrjohnson I fixed the buggy icon we saw in the standup. I also fixed some icon inconsistencies I saw (per the light on dark vs dark on light styling). I also also fixed how the ObjectiveSortManager displayed so the draggable icon now sits in the center like before. I know that was for a future PR but I figured it out, so :D

[michaelchadwick]

Still gotta fix the Session version of these things, tho...

[stopfstedt]

reviewed and click-tested. LGTM.

i spoke too soon. the course objectives version of this works as intended, but session objectives is bugged.

[michaelchadwick]

Got all the syncing stuff working, and fixed existing tests. Even without Code Climate warning me, I know new tests need to be written to account for the changes, but just want to make sure this is cool so far.

[dartajax]

[michaelchadwick]

@dartajax that's a valid visual point. I'm not sure yet how to improve the whitespace, but I will look into it.

[michaelchadwick]

@dartajax that extra space should be removed now

[dartajax]

looks great to me

[michaelchadwick]

Added Course Objective acceptance test (and improved FadeText integration test in the process). Now to work on the Session Objective acceptance test (which will be very similar, but still somewhat different).

[michaelchadwick]

Session acceptance test now in and working(?). CodeClimate still complaining -_- @jrjohnson @stopfstedt any ideas?

[michaelchadwick]

@dartajax Need a final review (Percy stuff) from ya, please :D

[jrjohnson]

OK to merge with failing code-climate test here.

[dartajax]

this looks good to me