Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes various minor issues with course viz #8224

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fixes various minor issues with course viz #8224

merged 2 commits into from
Nov 15, 2024

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Nov 12, 2024 •
edited
Loading

@stopfstedt stopfstedt marked this pull request as ready for review November 12, 2024 23:03
michaelchadwick
michaelchadwick approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@michaelchadwick michaelchadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Created new course, went to visualizations, and table was correctly not displayed for all types 👍
  • Went to existing course, checked existing visualization for session types, and noticed sorting titles now works 👍

@michaelchadwick
Copy link
Contributor

@stopfstedt Two things I noticed while reviewing this:

  1. Why show any visualization type to click on if clicking into each shows nothing? https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276
  2. Why show a filter box if there's nothing to filter? https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276/session-types and https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276/instructors

@stopfstedt
Copy link
Member Author

@stopfstedt Two things I noticed while reviewing this:

1. Why show any visualization type to click on if clicking into each shows nothing? https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276

what would you show instead here?

2. Why show a filter box if there's nothing to filter? https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276/session-types and https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276/instructors

yep, it's annoying and shouldn't be there.fixing that would require relocating the data loading process further up in the component hierarchy, or moving the filter input further down.

@michaelchadwick
Copy link
Contributor 

1. Why show any visualization type to click on if clicking into each shows nothing? https://deploy-preview-8224--ilios-frontend.netlify.app/data/courses/2276

what would you show instead here?

Maybe just show a "There are no visualizations to show because there is no course data yet." kind of statement?

dartajax
dartajax approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dartajax dartajax added the run ui tests Run the expensive UI tests label Nov 14, 2024
@dartajax dartajax merged commit 78f2bd6 into ilios:master Nov 15, 2024
43 checks passed
@stopfstedt stopfstedt deleted the thisnthat branch December 10, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartajax dartajax dartajax approved these changes

@michaelchadwick michaelchadwick michaelchadwick approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
run ui tests Run the expensive UI tests
Projects
None yet
Milestone
No milestone
3 participants
@stopfstedt @michaelchadwick @dartajax