Replace SASS imports #8229
Merged
Replace SASS imports #8229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
stopfstedt
approved these changes
Nov 14, 2024
michaelchadwick
approved these changes
Nov 14, 2024
dartajax
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@importsyntax is deprecated in sass. If I'm understanding this correctly we should use@usewhen we want the imported thing to appear in this place, but@forwardwhen we're saying when the containing file is@use'd we want to content to go there.Did a little bit of clicking around, seems like this works. Will need a review by @dartajax and then we'll let Percy do it's thing as well.