Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make froala link edit popup fully visible #8232

Merged

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5826

Made sidebar lower so popups show above it. There probably should be a test for this, but I'm not sure where in the suite this kind of thing would go (i.e. external dependency popup making).

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click tested in FF. LGTM

image

Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new z-index < old z-index but so much better

@dartajax dartajax added the run ui tests Run the expensive UI tests label Nov 15, 2024
@dartajax dartajax merged commit a41b5de into ilios:master Nov 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Way to Edit URL - Froala Text Entries - Out of Bounds
3 participants