Remove UserProfile render modifiers #8245
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
michaelchadwick
force-pushed
the
remove-user-profile-render-modifiers
branch
from
49b5d3f to
f818823
Compare
michaelchadwick
force-pushed
the
remove-user-profile-render-modifiers
branch
from
822c760 to
641f252
Compare
…ies on cancel so they last through an edit->cancel->edit
michaelchadwick
force-pushed
the
remove-user-profile-render-modifiers
branch
from
641f252 to
d421313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed pesky
ember-render-modifiersinstances in theUserProfileBioandUserProfileRolescomponents.refs ilios/ilios#5374
#8282 seems like a good model for breaking up
UserProfileBiointo-Details/Listand-Managercomponents.