Remove ChooseMaterialTypeComponent render modifiers #8266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
jrjohnson
approved these changes
Dec 13, 2024
stopfstedt
requested changes
Dec 13, 2024
| menuElement.querySelector('button:first-of-type').focus(); | ||
| focusFirstLink = task(async () => { | ||
| await timeout(1); | ||
| document.querySelector('.choose-material-type .menu button:first-of-type').focus(); |
There was a problem hiding this comment.
query should not be relative to the document root., but relative to the menu that the user is interacting with.
please see #8264 (comment)
There was a problem hiding this comment.
Nice catch, I didn't see this at all!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374