Remove common Course render modifiers #8274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
reviewed
Dec 18, 2024
| value={{this.courseTitle}} | ||
| {{on "input" (pick "target.value" (set this "courseTitle"))}} | ||
| {{on "keypress" (fn this.addErrorDisplayFor "courseTitle")}} | ||
| /> |
stopfstedt
reviewed
Dec 18, 2024
stopfstedt
reviewed
Dec 18, 2024
stopfstedt
reviewed
Dec 18, 2024
Comment on lines
+82
to
+84
| async getCourseSessions(course) { | ||
| await this.dataLoader.loadCourseSessions(course.id); | ||
| } |
There was a problem hiding this comment.
i think all of this can be scrapped without replacement. will send a follow-up PR for this.
There was a problem hiding this comment.
I ventured a guess that this could be done further upstream somehow (in the course route?), but wasn't sure how.
stopfstedt
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374
Removed from course header and objective list.