Remove MeshManagerComponent input render modifiers

[michaelchadwick]

Refs ilios/ilios#5374

[stopfstedt]

XHTML 👊

[stopfstedt]

this moveFocus() action doesn't seem to be wired up.

stefan@nichtsnutz: ~/dev/projects/frontend on remove-mesh-manager-input-render-modifiers[$]
$ grep -r 'moveFocus' packages --exclude-dir=dist --exclude-dir=node_modules
packages/ilios-common/addon/components/search-box.js:  moveFocus() {
packages/ilios-common/addon/components/search-box.js:    this.moveFocus();
packages/ilios-common/addon/components/mesh-manager.js:  moveFocus() {
packages/frontend/app/components/locale-chooser.js:  moveFocus(event) {
packages/frontend/app/components/locale-chooser.hbs:          {{on "keyup" this.moveFocus}}

proposing complete removal of this action and the horse that it rode in on, including the id/element stuff.

[michaelchadwick]

this moveFocus() action doesn't seem to be wired up.

@stopfstedt Excellent catch. I think I just assumed there was a magnifying glass icon in the Mesh Manager search input just like there is one in the Learning Materials one (and the general search box at the top). It's like that method was never wired up, actually.

However, since we already use the magnifying glass in other search inputs, should we not just add one here so it has one? To add an icon in one place or to remove the method across the board seems like a global question outside the scope of this PR.

[stopfstedt]

this moveFocus() action doesn't seem to be wired up.

@stopfstedt Excellent catch. I think I just assumed there was a magnifying glass icon in the Mesh Manager search input just like there is one in the Learning Materials one (and the general search box at the top). It's like that method was never wired up, actually.

However, since we already use the magnifying glass in other search inputs, should we not just add one here so it has one? To add an icon in one place or to remove the method across the board seems like a global question outside the scope of this PR.

that sounds even better than complete removal. go for it! the generic SearchBox component might be a good place to pilfer this from.

[michaelchadwick]

@stopfstedt Well, after trying to implement the magnifying glass icon in the search input, I realized why it probably isn't there: the input just autocompletes as you type. There's no reason to ever click an icon to "submit", so adding it is worthless at best, and potentially confusing at worst. I'm now not sure why we have it on the other search boxes, except for maybe accessibility reasons?

[stopfstedt]

sorry for giving you the runaround on this, but the since the need for getting a hold of this element within the component class is gone, some of this can be scrapped and the template can be reverted to the previous state (but leaving the nice cleanup intact).

[stopfstedt]

LGTM