fixed date-time issue, created validation, wrote tests #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,23 +1,28 @@ | |||
| import Ember from 'ember'; | |||
| import DS from 'ember-data'; | |||
| import moment from 'moment'; | |||
| import { translationMacro as t } from "ember-i18n"; | |||
There was a problem hiding this comment.
the translationmacro doesn't work for us right now because when we change language it doesn't change. This is fixed in the latest version, but that breaks some tests. You can update the package if you want and fix the broken tests, or you can just use a computed property which depends on 'i18n.locale' and then call this.get('i18n').t() to do the translation.
|
so close! still seeing the "if I don't take an action/make a change on a time value, it reverts to 12am on save" issue on offering edit. Appears to be fully resolved on offering creation. |
|
This looks good to go. |
|
👍 |
jrjohnson
added a commit
that referenced
this pull request
Oct 13, 2015
fixed date-time issue, created validation, wrote tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-flash-messagesoffering-editor,offering-manager, etc.