Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Admin and User Routes #887

Merged
merged 7 commits into from
Oct 15, 2015
Merged

Conversation

jrjohnson
Copy link
Member

This is bare bones skeleton stuff to add the /admin /users and /users/:user_id routes. I also added a global search component that currently only works for users, but should be able to work for many more things with time.

Need to fix up a few tests and get translation details.

@@ -94,6 +94,7 @@ export default {
'waitSaving': 'saving... one moment...',
'select': 'Select',
'invalidDatetimes': 'Invalid dates/times',
'globalSearchPlaceholder': 'Find Users...',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschaben / @dartajax please translate "Find Users..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fr.:"Trouver des utilisateurs..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es/Sp .. "Encontrar Usuarios..."

@saschaben
Copy link
Member

looking like a great start. is it possible to reverse the stacking of the live search control and the manage users button in their liquid container div? That would remove the "results push the button down the screen" issue with the live search control. I know it sort of mucks up the layout concept, but it's just a thought. If you tried it already and it either doesn't fly or looks like crap, that's fine. Just want to cover that issue since we discussed it yesterday.

Better alignment and got rid of the flicker when results come in.
@jrjohnson
Copy link
Member Author

It helps with the button pushing, but it would be temporary at best since more dashboard containers are going to end up on this page and they would get pushed down as well. I was successful in limiting the space by adding scroll bars to the search results so it only takes up 500px of vertical space no matter how many results there are.

thecoolestguy added a commit that referenced this pull request Oct 15, 2015
@thecoolestguy thecoolestguy merged commit b7d1589 into ilios:master Oct 15, 2015
@jrjohnson jrjohnson deleted the 790-adminroutes branch October 15, 2015 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants