Improved Topic Management #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing the topics down through the controller we can get them in the manager and display a spinner before they are loaded. This substantially speeds up the initial page rendering for a course.
Instead of making changes to the subject we store them in a buffer and apply them when saved. Also added a nice spinner icon when saving.
|
looks fine. ready for code review |
| }); | ||
| } | ||
|
|
||
| if(this.get('isSession')){ |
There was a problem hiding this comment.
Yea. I'm not sure how to do this right. Ideally I would probably create subclass components for each of these states but that seems like over kill. I felt like else if made it harder to understand because the blocks seemed related. Maybe I should stick a return inside each block so the next one isn't reached? Or move the sets out into functions here? Or I can just go else if, but it seems harder to read that way.
Use an elseIf construct and throw an error if one of the required isCourse, isSession, or isProgramYear are not set
|
@stopfstedt - how does that look. I added a thrown exception as well if none of them are set. |
|
LGTM 👍 |
|
@homu r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course and Program Year now load much faster since the list of available topics is not loaded until it is needed.
Fixes #820
The topic manager now works with a buffer instead of on the subject directly. So when you pick new topics, but do not save them they don’t show up other places on the page.
I also added a spinner to icon when topics are being saved. I think we can use this on all the managers, see what you think.
Fixes #629
Review link: http://56249ae971e20a33b200001d.zoo-keeper-levels-51188.netlify.com