Save offerings correctly #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dig! 👍 |
We’re not using this right now
This is part of the API so it should be on the model. The problem is the API wasn’t taking it in POST / PUT requests.
room is a required attribute of offering
jrjohnson
force-pushed
the
901-saveofferings
branch
from
fb2865e to
4bbbc1e
Compare
|
@homu +r |
1 similar comment
|
@homu +r |
|
@homu r+ |
|
📌 Commit 4bbbc1e has been approved by |
homu
added a commit
that referenced
this pull request
Oct 26, 2015
Save offerings correctly
Aligned the offering with the API. Along with some corresponding changes to the API this Fixes #901
jrjohnson
force-pushed
the
901-saveofferings
branch
from
4bbbc1e to
e7e2e0f
Compare
|
@homu r=stopfstedt |
|
📌 Commit e7e2e0f has been approved by |
|
👍 trying a review star to see if that kicks of homy |
thecoolestguy
added a commit
that referenced
this pull request
Oct 27, 2015
Save offerings correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned the offering with the API. Along with some corresponding changes to the API this Fixes #901