Group tests #936
Merged
Group tests #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are placed into group a.b.c so they can be split up and run in smaller batches. Hopefully this will make our CI builds more reliable and quick.
Since our tests are in groups now we can’t send test coverage anymore. Combined the unit tests in group A with the scss lint tests since that will all run fast.
Use grep to search all of the test files and discover any tests that did not import the test-groups helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my response to our failing tests. Hopefully it is temporary and phantom js 2 will become more stable. I created 2 test groups (itga, itgb, itgc) - stands for Ilios Test Group - and placed our tests in one of those groups. Even if tests fail they should be easier and faster to restart.
The grouping is done by appending the test group name to the test description and then using the testem filter option to only run those that match the group name.
I added a grep test as well which checks to see that the test-groups helper is imported into each test file. This is the best I could come up with for a way to check that each set of tests was in at least one group.