Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow admin to join course #164

Merged
merged 2 commits into from
Nov 14, 2018
Merged

allow admin to join course #164

merged 2 commits into from
Nov 14, 2018

Conversation

genevievehelsel
Copy link
Collaborator

@genevievehelsel genevievehelsel commented Nov 14, 2018 •
edited
Loading

allow an admin to join course, since everything was already in place for this (including test cases surprisingly), we just have to show the button

fixes #116

@vercel
Copy link

vercel bot commented Nov 14, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

nwalters512
nwalters512 approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This has been on my todo list for a while 🙂

@nwalters512 nwalters512 merged commit b06ba48 into master Nov 14, 2018
@nwalters512 nwalters512 deleted the allow-admin-join-course branch November 14, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwalters512 nwalters512 nwalters512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admins should be able to join a queue as staff
2 participants
@genevievehelsel @nwalters512