Confidential queues! #230
Merged
Confidential queues! #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new confidential toggle * Add isConfidential column and make some frontend changes for anon users * Fix student not seeing their own question on a confidential queue * Change wording of confidential queue description * Change eye icon to be on left of queue name instead of right * Add some backend queue confidential features * Clean up code * Edit confidential queue to only display a message * Fix database and linting errors * Change order of sequelize model * Fix QueueCard text issue and NewQueue toggle issue * Fix toggling message resulting in reset of confidentiality, add tests for confidential queues * Make QuestionList look cleaner, clean up formatting * Change confidential queue tooltip for students, add ability for admins to see confidential queue students * Fix admin not seeing question list error * Fix prettier issue * Fix prettier issues for real * Delete old code, fix message for admins * Change ConfidentialQueuePanel to function component * Fix confidential queue message bug with number of questions * Remove eslint-disable
* Filter question details from API for confidential queues * Exclude confidential question information from API * Don't expose confidential information over websocket * Document design choices for websocket * Fix bug; push question updates to asker * Expand tests for confidential queues * Fix emitting events to all necessary rooms
nwalters512
requested review from
wadefagen,
james9909,
genevievehelsel and
jackieo5023
|
This pull request is automatically deployed with Now. |
jackieo5023
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the work from #199 and #224 that implements the frontend and backend for confidential queues. #224 tested the combined work pretty extensively; this PR is just a final chance to review everything in one place before we ship it.