Refactoring for multiple logins and institutions #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
james9909
approved these changes
Sep 17, 2019
jackieo5023
approved these changes
Sep 17, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial step towards multi-org support outlined in #282. This doesn't attempt to add the concept of organizations or do the fancy account linking proposed there. Rather, it begins to move us away from being hardcoded for Illinois Shib accounts and towards a more generic system that we can use to add Google authentication and allow the queue to be deployed at UBC. Namely, it replaces
netidwithuidon the users table, where a user's UID is a globally-unique identifier for them. This could be[email protected]for Illinois Shib,[email protected]for Google login, or a student's hash for a UBC deployment. Also adds support for configuring how such identifiers are referred to in the UI in the form ofuidName(e.g. "Illinois email") anduidArticle(e.g. "an") which can be combined to refer to a specific form of UID for an institution.This also refactors the user autocomplete box from the admin page into a self-contained
UserAutocompletecomponent and uses it on the course staff page.Currently a draft; opening the PR for feedback and so I can see all my changes in one place.