-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download queue data button #290
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5e0203b
Add sequelize query to fetch course data
jackieo5023 5f0ecc7
Add ability to download csv of data
jackieo5023 45a7e06
Fix lint
jackieo5023 7b15ea9
Move csv logic to api
jackieo5023 eeadbe5
Add test for data/questions endpoint
jackieo5023 28d8e32
Filter columns by what we want to include
jackieo5023 811069b
Merge branch 'master' of https://github.com/illinois/queue into downl…
jackieo5023 d865e0e
Merge branch 'master' of https://github.com/illinois/queue into downl…
jackieo5023 2f4bff8
Merge branch 'download-queue-data' of https://github.com/illinois/que…
jackieo5023 65baefa
Move timezone calculation to javascript side to get rid of sqlite/mys…
jackieo5023 e0df273
Add time format
jackieo5023 4b5a248
Merge branch 'download-queue-data-fix' into download-queue-data
jackieo5023 7e769e2
Change test times to UTC
jackieo5023 7ed2b65
Change how data is downloaded, add changelog entry
jackieo5023 440ea80
Get rid of getColumns, add withBaseUrl
jackieo5023 8edd3ab
Fix user location column name
jackieo5023 1a0e6f2
Fix test
jackieo5023 d2e11a5
Fix test for real
jackieo5023 1e29774
Fix tests for real for real I promise
jackieo5023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: this may be undesirable if/when we roll out to schools like UBC that aren't in the central timezone. When that happens, we should either a) report times in UTC and allow consumers of this data to transform it as needed, or b) associate some concept of timezone with either courses or institutions (one institutions are an entity that we have). I think I'd prefer the latter; at any rate, that's outside the scope of this PR.