Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Confirmation Prompt for Cancelling and Deleting Student Questions #71

Merged
merged 9 commits into from
Mar 19, 2018

Conversation

muakasan
Copy link
Collaborator

Resolves #47

@muakasan muakasan requested a review from nwalters512 March 18, 2018 05:04
@nwalters512
Copy link
Member

Loving this refactoring work <3 will do a full review when I'm more awake tomorrow. In the meantime, want to fix the ESLint errors and write a changelog entry?

It might make sense to move the redirectNoQueue change into another branch + PR so we can review + discuss separately.

@muakasan muakasan force-pushed the confirm-delete-cancel branch from dfbd39b to ba334f3 Compare March 18, 2018 05:31
@muakasan muakasan force-pushed the confirm-delete-cancel branch from ba334f3 to 089bad7 Compare March 18, 2018 05:39
Copy link
Member

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Aidan! Thanks for this 😄

CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ with the current date and the next changes should go under a **[Next]** header.

* Improve spacing of course buttons on homepage. ([@nwalters512](https://github.com/nwalters512) in [#60](https://github.com/illinois/queue/pull/60))
* Add support and tooling for Sequelize database migrations. ([@nwalters512](https://github.com/nwalters512) in [#56](https://github.com/illinois/queue/pull/56))
* Add Confirmation Prompt for Cancelling and Deleting Student Questions. ([@muakasan](https://github.com/muakasan) in [#71](https://github.com/illinois/queue/pull/71))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence case please 😛

@muakasan
Copy link
Collaborator Author

image
tfw you're too lazy to open the file in your editor

@nwalters512 nwalters512 merged commit f663750 into master Mar 19, 2018
@nwalters512 nwalters512 deleted the confirm-delete-cancel branch March 19, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants