Skip to content

Commit

Permalink
hotfix: remove a warning and a note from devtools::check()
Browse files Browse the repository at this point in the history
- remove warning due "Undocumented arguments in documentation object" in fill_desc

- add forgotten @importFrom utils person that caused a note
  • Loading branch information
ilyaZar authored and ColinFay committed May 24, 2023
1 parent f730550 commit d458270
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ importFrom(utils,file.edit)
importFrom(utils,getFromNamespace)
importFrom(utils,menu)
importFrom(utils,modifyList)
importFrom(utils,person)
importFrom(utils,sessionInfo)
importFrom(yaml,read_yaml)
importFrom(yaml,write_yaml)
9 changes: 8 additions & 1 deletion R/desc.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@
#' @param repo_url URL (if needed)
#' @param pkg_version The version of the package. Default is 0.0.0.9000
#' @param pkg Path to look for the DESCRIPTION. Default is `get_golem_wd()`.
#'
#' @param author_first_name to be deprecated: use character for first name via
#' \code{authors = person(given = "authors_first_name")} instead
#' @param author_last_name to be deprecated: use character for last name via
#' \code{authors = person(given = "authors_last_name")} instead
#' @param author_email to be deprecated: use character for first name via
#' \code{authors = person(email = "author_email")} instead
#' @param author_orcid to be deprecated
#'
#' @export
#' @importFrom utils person
#'
#' @return The {desc} object, invisibly.
fill_desc <- function(
Expand Down

0 comments on commit d458270

Please sign in to comment.