-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of cart workflow #63
Conversation
…t with Ubuntu env variables
Alter readme to avoid this fork from productional use
Add cart workflow - NOT FUNCTIONAL YET
aligned de language file with en language file
Feature/add cart backup
fix: check balance amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a lot of work to be done before pouring in that PR.
General Comments:
- Use an approach that is already in use at the moment:
- Commas at the beginning instead of at the end;
- Distinguish models for SQLAlchemy from previous models;
- Products in cart can be shown the same way as Subcategories.
All this is unnecessary and makes the code heterogeneous.
- There should not be any comments in the files, only TODO is allowed.
- Do not add useless files that are not used anywhere, even if you plan to use the code from these files later, they are of no use now.
- Don't create formatting changes, this causes the file to show up as changed, even though the actual essence of the file hasn't changed. This increases the cognitive load for the PR checker.
(cherry picked from commit 9da2cfa)
Done
Please elaborate
IMO these are two separate entities. If any, the CartItem resembles more the Buy Entity but still I think that you need a different entity. Here is why:
Happy to discuss
I'll follow your direction, although I think that comments don't hurt anyone. I had to understand your way of thinking for some time and comments would have helped me a lot. If you change your point of view here, let me know, please. Until then, I remove the comments (I do not mean commented code but actual comments btw)
Agreed and removed.
Agreed, will improve myself here, thank you |
Changes according to review comments from PR
rollback of buyItem according to PR feedback
continuing to work on PR review
Rebase cart workflow onto development branch
# Conflicts: # handlers/user/all_categories.py # l10n/de.json # l10n/en.json # run.py # services/category.py # utils/notification_manager.py
# Conflicts: # handlers/user/all_categories.py # l10n/de.json # l10n/en.json # run.py # services/category.py # utils/notification_manager.py
What was meant here is that you need to rework the way you describe the model fields. What I described in the 1st paragraph with screenshots.
|
Added pagination to the cart. The functionality related to the “CartItem” entity has been moved to a separate service. Cart is initialized for each user during registration. Overall code refactoring was done.
removed .env.template, removed redundant constants from .env
The “Cart” and “CartItem” table models have been reworked.
The feature includes two models: cart and cart item. The cart is created as an intermediate step between the selection of the goods so that a customer can collect items in said cart as cart items and check them out in one step.
Resolves request #69