Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #72

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add unit tests #72

wants to merge 1 commit into from

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Oct 23, 2019

While I initially thought unit testing would be easy, I now have to conclude it is not that simple 🙄

@dagwieers dagwieers force-pushed the unit branch 3 times, most recently from edb89cd to fab4a13 Compare October 23, 2019 02:19
@dagwieers
Copy link
Collaborator Author

Basic encoding unit tests have been added in #93

@im85288
Copy link
Owner

im85288 commented Nov 27, 2019

@dagwieers The Travis build is failing with an issue with Python 3.5. This is what I could see in the logs

`
Traceback (most recent call last):
File "/home/travis/build/im85288/service.upnext/test/test_encoding.py", line 71, in test_to_addon_signals
decoded_data = AddonSignals._decodeData('["%s"]' % encoded_data) # pylint: disable=protected-access
File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/AddonSignals.py", line 21, in _decodeData
return json.loads(base64.b64decode(data[0]))
File "/opt/python/3.5.6/lib/python3.5/json/init.py", line 312, in loads
s.class.name))
TypeError: the JSON object must be str, not 'bytes

`

Hopefully you have access to the Travis results? https://travis-ci.org/im85288/service.upnext/builds/617623308?utm_medium=notification&utm_source=email

@dagwieers
Copy link
Collaborator Author

Our unit tests are failing for a genuine bug in Addon Signals: ruuk/script.module.addon.signals#6

We are also waiting for ruuk/script.module.addon.signals#4 to be merged so we can use the upstream master branch, rather than my branch.

@dagwieers dagwieers mentioned this pull request Dec 24, 2019
@dagwieers dagwieers added the testing Related to automated testing label Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants