Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readUtf8 and writeUtf8 #32

Merged
merged 1 commit into from
Dec 27, 2016
Merged

feat: add readUtf8 and writeUtf8 #32

merged 1 commit into from
Dec 27, 2016

Conversation

targos
Copy link
Member

@targos targos commented Dec 26, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 26, 2016

Current coverage is 100% (diff: 100%)

Merging #32 into master will not change coverage

@@           master   #32   diff @@
===================================
  Files           1     1          
  Lines         197   205     +8   
  Methods        43    45     +2   
  Messages        0     0          
  Branches       17    18     +1   
===================================
+ Hits          197   205     +8   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 2c6e104...6118a54

@targos targos mentioned this pull request Dec 26, 2016
@targos
Copy link
Member Author

targos commented Dec 26, 2016

@windwp is that what you need?

@targos
Copy link
Member Author

targos commented Dec 26, 2016

@stropitek @maasencioh what do you think?

@maasencioh
Copy link
Contributor

LGTM if you already test the utf8 library

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe it would make sense to also implement a readUtf8Char that is smart about the number of byte it reads. I think utf-8 makes it very easy to know how many bytes to read by reading the first byte.

@targos targos merged commit 6118a54 into master Dec 27, 2016
@targos targos deleted the utf8 branch December 27, 2016 12:00
@targos
Copy link
Member Author

targos commented Dec 27, 2016

Thanks. Merged and released in v3.2.0

@targos
Copy link
Member Author

targos commented Dec 27, 2016

Maybe it would make sense to also implement a readUtf8Char that is smart about the number of byte it reads.

Yeah, I don't know of a library that can do that. We should do it only if we know about a format that specifies the number of characters to read instead of the number of bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants