Add support for parsing eXIf chunk.
#568
Open
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `eXIf` chunk was already supported in `encoder.rs`, but this commit also adds support to `decoder/stream.rs`. This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/390707316
anforowicz
force-pushed
the
exif-chunk-decoding
branch
from
643d290 to
aa16ef9
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 18, 2025
This CL (together with image-rs/image-png#568 and http://review.skia.org/937702) is needed to pass `external/wpt/css/css-images/image-orientation/image-orientation-exif-png-2.html` when using `SkPngRustCodec`. Bug: chromium:390707316 Change-Id: I9255e8dba666113a91c7d82ba461b565fc5c5e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6183155 Auto-Submit: Łukasz Anforowicz <[email protected]> Reviewed-by: Peter Kasting <[email protected]> Commit-Queue: Peter Kasting <[email protected]> Cr-Commit-Position: refs/heads/main@{#1408322}
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jan 22, 2025
This CL parses the `eXIf` data reported by the `png` crate and exposes the image orientation (`SkEncodedOrigin`) through `SkCodec`'s public API. This CL depends on `png` crate populating/reporting the decoded `eXIf` chunk's data - this is being implemented in image-rs/image-png#568 Bug: chromium:390707316 Change-Id: Ieaf05c772e7a74492f5312f103b132bc888806d4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/937702 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Łukasz Anforowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eXIfchunk was already supported inencoder.rs, but this commit also adds support todecoder/stream.rs. This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/390707316