-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GUI Pose Views for Dawntrail #1369
Update GUI Pose Views for Dawntrail #1369
Conversation
9206e59
to
c512b27
Compare
After carrying out some testing, I believe that the features are in a good state and ready for review. The following images are showcases of the layout and visuals of the two panels: Miqo'te: Standard Faces (Hyur, Lalafell, Elezen, Au'Ra, Roegadyn): Hrothgar: Viera - Straight Ears (M: 1, 3, 4 | F: 1, 2, 4): Viera - Floppy Ears (M: 2 | F: 3): |
In your Miqo'te Previews you have a line going from center mouth to detail view, thats not present in the others (and doesnt appear to be present in the build). Is this intended? For what its worth, I dont think the line is needed, I just want to make sure theres intent behind it. |
It is present on all face types. It should appear once you hover within the mouth selectors' background. I can remove it if you believe its unnecessary as I don't feel strongly about it. The reason behind adding it in the first place is to showcase what part of the face you're editing since its detached from the main component. |
AH! You are absolutely right, I did not pay attention to that lmao. Nah thats actually neat, goes out of the way when not needed but may help some people figure out what exactly it is. |
One request I would make, to avoid the same situation we have now; How did you edit these screenshots you used for the 2D View. |
Good idea. I will push a new commit later today with the .psd source files for all of the new images. I can also share the step-by-step process of how I created them if you think it would be useful. Concerning the directory name, I can call it "SourceFiles" or "RawAssets" but I think "Templates" is suitable as well. |
I like RawAssets! Not sure where such a step by step write up would go, potentially in the same folder as Readme? Nur sure where such things usually go... |
After some consideration, I believe that a step-by-step guidelines file is an overkill as all important aspects can be inherently understood by examining the .psd files.
Notes:
|
ee0f6aa
to
1839367
Compare
As the pull request has not yet been fully approved and merged, I thought it would be a good opportunity to push in a hotfix regarding my initial auto hair bone selection logic as I realized there was a significant flaw to it - it forces the conversion on all bones, in all views, including the Matrix View and the 3D View. In other words, it made the generic bones inaccessible as the BoneView would point to the hairstyle-specific bone whenever present. There are a handful of hairstyles that seem to utilize both the unique hair bones and the generic ones, so this is not desired. I revised the code (commit 1839367) by creating custom bone names that will only be used in the GUI Views. Essentially, the GUI Views will try to automatically select the best hair bones for you. In the occasions where the unique bones do not work or are not what you're looking for, you will now be able to switch to either the Matrix View or the 3D View to manually select them. |
Good catch on that. I will go through one final time on the changes today and unless @chirpxiv has any objections I'd merge it sometime tonight or tomorrow. |
This is basically tomorrow, right? |
This pull request updates the existing GUI Pose View to align with Dawntrail’s bone changes and introduces a new view for extended face manipulation. As the change is significant, I created two mockups to base my implementation's UI layout on.
Mockups:
![anam-2d-panel-body-mockup](https://private-user-images.githubusercontent.com/177319566/356880905-9bd98a1c-33ab-4a1a-ba6e-db92393e4a4a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzU5MzEsIm5iZiI6MTczOTMzNTYzMSwicGF0aCI6Ii8xNzczMTk1NjYvMzU2ODgwOTA1LTliZDk4YTFjLTMzYWItNGExYS1iYTZlLWRiOTIzOTNlNGE0YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDQ3MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lYWVkMTgzYzE4YzNkMmVjNjliZjIwYTEyYjZjZDc2MjA5ZDZmMjgwNWJhYjBlYjM2NGM3YTEyY2JjMzc3YTlkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.FH1NBiylrFlHGlaUVLTV5GQnxLpoHQQZzCyWi0swemE)
![anam-2d-panel-face-mockup-v2](https://private-user-images.githubusercontent.com/177319566/357608374-daa94162-2d89-40d4-98c6-cda88a80f61e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzU5MzEsIm5iZiI6MTczOTMzNTYzMSwicGF0aCI6Ii8xNzczMTk1NjYvMzU3NjA4Mzc0LWRhYTk0MTYyLTJkODktNDBkNC05OGM2LWNkYTg4YTgwZjYxZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDQ3MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOTZiMWMwZTNmZWVhOGI1MjE0YjBiODJjMGQ3NWE3ZmQ5YmNhNGU5MzIwOTYzMzdlZWJmYzk5ODkxYzFiZWU3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.m2QWhwTJQf_0kootsolIJBNZnlxIB-cbQdN8dn-gmtI)
Changes:
Status: