fixes pose flipping no longer working #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes logic for finding the left/right bone (assumes a 'left' bone aways ends with '_l' and 'right' bones end with '_r') updates flip rotation to use the new TransformMemory system
|
Awesome, glad it wasn't too painful to track down. I'll do some testing. |
|
Thanks a lot! :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#610 looks this should fix the pose flipping (didn't thoroughly test it but looks to be working as expected now)
ended up being one of the rotations not getting updated to the new TransformMemory system and updating to the new bone naming convention