Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Overriding #733

Merged
merged 19 commits into from
Dec 29, 2021
Merged

Animation Overriding #733

merged 19 commits into from
Dec 29, 2021

Conversation

AsgardXIV
Copy link
Contributor

@AsgardXIV AsgardXIV commented Dec 26, 2021

Ok, so this is my second implementation of animation overriding (the previous one is still in a branch if we need it).

This basically takes an approach very similar to CMTool but wraps it in a nicer interface and some logic which makes the user experience better.

This directly plays animations, so you want IDs from the ActionTimeline sheet.

It's possible for players to loop automatically with some code tweaks, but I figured a universal option to let the user choose the loop time so it can be used with BattleNPCs, EventNPCs etc. Setting repeat to 0 plays the animation once.

This also allows forcing characters to draw/equip weapons.

UI is placeholder.

@AsgardXIV AsgardXIV marked this pull request as draft December 26, 2021 08:58
@AsgardXIV AsgardXIV marked this pull request as ready for review December 27, 2021 05:34
@AsgardXIV
Copy link
Contributor Author

AnimationHelp.md

@Yuki-Codes Yuki-Codes merged commit 9717683 into imchillin:master Dec 29, 2021
@Yuki-Codes
Copy link
Contributor

going to merge this in now, and get started on an improved UI. Will try to leave the underlying code alone incase there are more tweaks coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants