-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation Overriding #733
Merged
Merged
Animation Overriding #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o animationcontrol
going to merge this in now, and get started on an improved UI. Will try to leave the underlying code alone incase there are more tweaks coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so this is my second implementation of animation overriding (the previous one is still in a branch if we need it).
This basically takes an approach very similar to CMTool but wraps it in a nicer interface and some logic which makes the user experience better.
This directly plays animations, so you want IDs from the
ActionTimeline
sheet.It's possible for players to loop automatically with some code tweaks, but I figured a universal option to let the user choose the loop time so it can be used with BattleNPCs, EventNPCs etc. Setting repeat to 0 plays the animation once.
This also allows forcing characters to draw/equip weapons.
UI is placeholder.