Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace opts[:host] with opts[:domain] to suppress deprecated warnings #96

Merged

Conversation

takamario
Copy link
Contributor

@takamario takamario commented Jul 30, 2020

The purpose of this PR is to resolve deprecation warnings being thrown
as a result of using imgix-rb version 3.3.0, see here.

@ericdeansanchez ericdeansanchez self-assigned this Jul 30, 2020
@ericdeansanchez
Copy link
Contributor

Hey @takamario 👋 thanks for this! We really appreciate it. I'm going to update/edit the commit message a bit before merging this in, but I think this PR checks all the boxes. Thanks!

@ericdeansanchez ericdeansanchez merged commit 83adc1d into imgix:master Jul 30, 2020
@takamario takamario deleted the suppress-host-deprecated-warnings branch July 31, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants