fix: deprecate ParamHelpers.rect #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
suggested changes
Jul 13, 2020
There was a problem hiding this comment.
Could we add a test here to ensure that the warning is getting emitted as expected? There are some examples in #43 you can work off of.
|
Yeah! Let's! |
ericdeansanchez
force-pushed
the
deprecate-param-helpers
branch
from
17a1099 to
b298e89
Compare
ericdeansanchez
force-pushed
the
deprecate-param-helpers
branch
from
b298e89 to
5a3ba8b
Compare
ericdeansanchez
requested review from
sherwinski
and removed request for
sherwinski
sherwinski
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to warn users that
ParamHelpers.recthas beendeprecated and will be removed from the next major version.