改进模型自动创建时间和更新时间 #525
Merged
改进模型自动创建时间和更新时间 #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NHZEX
commented
May 26, 2023
NHZEX
commented
- 允许模型输入时间覆盖自动生成行为
- 改进模型的自动时间测试
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 2.1 #525 +/- ##
============================================
- Coverage 65.20% 64.39% -0.81%
- Complexity 10987 10999 +12
============================================
Files 881 881
Lines 30050 30055 +5
============================================
- Hits 19594 19355 -239
- Misses 10456 10700 +244
☔ View full report in Codecov by Sentry. |
NHZEX
force-pushed
the
dev/model-auto-time
branch
from
e0d2232 to
b2c4ad7
Compare
Yurunsoft
reviewed
Jun 3, 2023
NHZEX
force-pushed
the
dev/model-auto-time
branch
from
e3f525f to
fbf52f9
Compare
Yurunsoft
reviewed
Jun 4, 2023
src/Model/Model.php
Outdated
| @@ -1028,6 +1030,7 @@ private static function parseSaveData($data, string $type, ?self $object = null) | |||
| } | |||
| $incrUpdate = $meta->isIncrUpdate(); | |||
| $ids = $meta->getIds(); | |||
| $microTime = microtime(true); | |||
There was a problem hiding this comment.
创建时间和更新时间字段不一定存在，要不要把下面用到的的 $microTime 改成 $microTime ??=microtime(true)
Yurunsoft
reviewed
Jun 6, 2023
NHZEX
added a commit
to NHZEX/imi
that referenced
this pull request
Oct 18, 2023
* update 模型自动时间支持传入覆盖 * 调整 * 兼容pg更改 * 修复更新时无法写入更新时间 * 修复测试 * 修复测试 * 移除多余的类型转换 * 改进pg的测试 * 修复格式 * 调整时间赋值时机 * 改进格式
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.