-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHActions/JamesIves/github-pages-deploy-action to 4.0.0 for all repos #151
Comments
Since there is no repository specific difference over bikeshed repositories, I will run script shortly (targeting Wed) - tested with my fork and working fine. |
@himorin thank you! |
done. (log)
Failure on webxr was due to test mentioned in an initial comment of this issue, fixed by hand operation. If you get any issue, please reopen this issue. |
This reverts commit e03cfc5.
This reverts commit e03cfc5.
Hi @himorin, thanks for updating the deploy script! In the future, could you please send a pull request? I have modified the deploy.yml file in the depth-sensing repo to only deploy bikeshed build artifacts (index.html and the img/ folder used by the specification) into gh-pages branch instead of the entire repository, and it seems that your script paved over those changes. We could also come up with some way to manage the repos automatically, but issuing a PR would at least reduce the surprise that I had when I navigated to https://immersive-web.github.io/depth-sensing/. :) |
@bialpio Thank you for pointing this. Actually opening and merging large number of PRs are huge task since we have number of repositories as above, and we took a way of directly commit to the default branch. WG/CG concluded that we don't need a standardized way/manual for setting up repositories, but considering this kind of operation, I suppose we might be better to have some standard (or well considered script(s)) on this area. |
I think the main problem with using the same GHAction for every repo is that it assumes that the outputs of a Makefile will be produced in-place alongside the rest of the repository. For depth sensing (and I think for hit-test & anchors) I used a Makefile that produced output to a dedicated out/ directory & published just that. I will roll back my changes to the Makefile in depth-sensing repo (others have been modified during migration to GHActions and I have not touched them since, so they should still work) so that it is easier to manage the large amount of repos using the existing scripts, but it would be great if all assumptions that the automated scripts make were listed somewhere, as they may be broken by other repos down the line. For example, real world geometry repo may end up having 2 .bs files since we used it for incubating plane detection and mesh reconstruction - using a Makefile that expects an index.bs will not work there. |
4.0.0 has released and release note notes that GITHUB_TOKEN is no longer required. So, let me propose to update all repositories with 4.0.0 and removing GITHUB_TOKEN.
Test worked well at my fork: https://github.com/himorin/webxr/runs/1852857068
/cc @Yonet @AdaRoseCannon @cwilso
The text was updated successfully, but these errors were encountered: