Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use degrees instead of radians for Chrome 66+ deviceorientation events #18

Closed
jsantell opened this issue Mar 2, 2018 · 1 comment
Closed

Use degrees instead of radians for Chrome 66+ deviceorientation events #18

jsantell opened this issue Mar 2, 2018 · 1 comment

Comments

@jsantell
Copy link
Contributor

jsantell commented Mar 2, 2018 •
edited
Loading

In Chrome Canary m66, the deviceorientation event's rotationRate is now reported in degrees rather than radians, like other browsers. Chromium bug.

Not sure of a clever way of distinguishing between pre-66 Chrome events outside of UA string parsing.
@jsantell jsantell mentioned this issue Mar 3, 2018
Closed
@jsantell jsantell changed the title Use degrees instead of radians for Chrome 66+ deviceorientation events Use degrees instead of radians for Chrome 65+ deviceorientation events Mar 3, 2018
@jsantell
Copy link
Contributor Author

jsantell commented Mar 3, 2018 •
edited
Loading

Edit: Change is being pushed to m65 to fix another issue, which means this is high priority to cut a new release and uplift to the polyfill; this will affect all consumers on latest stable once m65 is uplifted, sometime next week.
Confirmed, this will be in m66, not m65.

@jsantell jsantell changed the title Use degrees instead of radians for Chrome 65+ deviceorientation events Use degrees instead of radians for Chrome 66+ deviceorientation events Mar 5, 2018
jsantell added a commit that referenced this issue Mar 5, 2018
@jsantell
Handle Chrome m66+'s change of reporting a deviceorientation rotation…
bc811c4 
…Rate in degrees, rather than (incorrect) radians. Fixes #18
@jsantell jsantell mentioned this issue Mar 5, 2018
Merged
jsantell added a commit that referenced this issue Mar 5, 2018
@jsantell
Handle Chrome m66+'s change of reporting a deviceorientation rotation…
75a6d51 
…Rate in degrees, rather than (incorrect) radians. Fixes #18
@dustinkerstein dustinkerstein mentioned this issue Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsantell