fix(errors): log when a deferred transaction rollback does not work

immobiliare · Jan 17, 2024 · 7d51e71 · 7d51e71
1 parent 61f4f66
commit 7d51e71
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/mold/count.go b/mold/count.go
@@ -1,6 +1,7 @@
 package mold
 
 import (
+	"github.com/sirupsen/logrus"
 	"github.com/xujiajun/nutsdb"
 )
 
@@ -14,7 +15,12 @@ func (db *Mold) Count(filter string) (int, error) {
 	if err != nil {
 		return -1, err
 	}
-	defer tx.Rollback()
+	defer func() {
+		err := tx.Rollback()
+		if err != nil {
+			logrus.Debugln(err.Error())
+		}
+	}()
 
 	if filter != "" {
 		data, _, err = tx.PrefixSearchScan(bucket, []byte{}, filter, 0, -1)

diff --git a/mold/read.go b/mold/read.go
@@ -3,14 +3,20 @@ package mold
 import (
 	_event "github.com/immobiliare/peephole/mold/event"
 	_util "github.com/immobiliare/peephole/util"
+	"github.com/sirupsen/logrus"
 )
 
 func (db *Mold) Read(id string) (*_event.Event, error) {
 	tx, err := db.Begin(false)
 	if err != nil {
 		return nil, err
 	}
-	defer tx.Rollback()
+	defer func() {
+		err := tx.Rollback()
+		if err != nil {
+			logrus.Debugln(err.Error())
+		}
+	}()
 
 	data, err := tx.Get(bucket, []byte(id))
 	if err != nil && err.Error() == "key not found" {

diff --git a/mold/select.go b/mold/select.go
@@ -3,6 +3,7 @@ package mold
 import (
 	_event "github.com/immobiliare/peephole/mold/event"
 	_util "github.com/immobiliare/peephole/util"
+	"github.com/sirupsen/logrus"
 	"github.com/xujiajun/nutsdb"
 )
 
@@ -16,7 +17,12 @@ func (db *Mold) Select(filter string, page, limit int) ([]_event.Event, error) {
 	if err != nil {
 		return []_event.Event{}, err
 	}
-	defer tx.Rollback()
+	defer func() {
+		err := tx.Rollback()
+		if err != nil {
+			logrus.Debugln(err.Error())
+		}
+	}()
 
 	if filter != "" {
 		data, _, err = tx.PrefixSearchScan(bucket, []byte{}, filter, page*limit, limit)