rustdesk-server: add the init.d file for rustdesk-server #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yun <[email protected]>
1715173329
requested changes
Jan 4, 2025
| @@ -30,6 +30,11 @@ define Package/rustdesk-server | |||
| URL:=https://rustdesk.com/server | |||
| endef | |||
|
|
|||
| define Package/rustdesk-server/install | |||
| $(INSTALL_DIR) $(1)/etc/init.d | |||
There was a problem hiding this comment.
you need to add commands for installing the binaries too since you have overridden the default install recipe.
otherwise only this script will be packed.
| START=99 | ||
| STOP=10 | ||
| USE_PROCD=1 | ||
| NAME="rustdesk" |
There was a problem hiding this comment.
Suggested change
| NAME="rustdesk" | |
| NAME="rustdesk" |
| WORKDIR="/etc/rustdesk" | ||
|
|
||
| start_service() { | ||
| if [ ! -d "$WORKDIR" ]; then |
There was a problem hiding this comment.
please use tabs for indentation.
Comment on lines
+11
to
+12
| mkdir -p "$WORKDIR" | ||
| if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
Suggested change
| mkdir -p "$WORKDIR" | |
| if [ $? -ne 0 ]; then | |
| if ! mkdir -p "$WORKDIR"; then |
i would say this error is unlikely to happen, no need to check here
| fi | ||
|
|
||
| procd_open_instance "$NAME.server" | ||
| procd_set_param cwd "$WORKDIR" |
Comment on lines
+35
to
+43
| stop_service() { | ||
| killall hbbs | ||
| killall hbbr | ||
| } | ||
|
|
||
| reload_service() { | ||
| stop_service | ||
| start_service | ||
| } |
There was a problem hiding this comment.
Suggested change
| stop_service() { | |
| killall hbbs | |
| killall hbbr | |
| } | |
| reload_service() { | |
| stop_service | |
| start_service | |
| } |
procd will handle these, drop
|
|
||
| procd_open_instance "$NAME.server" | ||
| procd_set_param cwd "$WORKDIR" | ||
| procd_set_param command sh -c "cd $WORKDIR && /usr/bin/hbbs" |
There was a problem hiding this comment.
this is... ugly. needs a way to get rid of sh wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.