-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.17.0 #802
Release 0.17.0 #802
Conversation
Hoping to make the release late Monday if no issues crop up. |
d52a00a
to
9da082f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things missing from this. Published packages require description
, license
/license-file
, and documentation
/homepage
/repository
fields, which most of the new packages don't have. To fix part of this, I opened #804, which also unifies package versions, which makes this PR simpler. #805 then adds the package descriptions.
Also, I don't think we should bump version numbers for the unmaintained packages, namely c2rust-macros
and c2rust-refactor
. I don't think we should publish new versions of them if they are unchanged and unmaintained.
I'm also not sure the update-versions.sh
script is the best idea vs. something much more polished and widely used like cargo-release
. cargo-release
should get all the little details right that this script probably won't. For example, it immediately detected that we're missing a bunch of the required package fields for publishing. If there's a suitable alternative that's fairly widely used, I think that's better than our own script that we'll have to maintain, which also adds dependencies on things like sponge
.
Regardless, I think we should merge #804 first, which then simplifies this PR, and also open a PR that includes description
s for all of the new packages (#805).
Sharing versions via workspace inheritance breaks the script anyway, so I've removed it. I also couldn't get |
9da082f
to
67a2cfd
Compare
I think we should bump version numbers for all crates in the repo to avoid divergence. If we want to delete the c2rust-refactor and c2rust-macros crates entirely, we can--they'll still be in the history. We don't need to release old, deprecated crates on crates.io, nor do I think it makes sense to release the new analysis/runtime/pdg crates; they aren't in any state where it would be a good idea to get them from crates.io rather than GitHub. We should release just these crates:
|
67a2cfd
to
7e4e433
Compare
Not sure it's the best idea, but I don't think it really matters either way. They were bumped to
👍
👍
👍 , except I think there's a typo in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, but otherwise I think it's all good for a release now!
@@ -19,11 +19,11 @@ assert_matches = "1.5.0" | |||
indexmap = "1.9.2" | |||
|
|||
[build-dependencies] | |||
c2rust-build-paths = { path = "../c2rust-build-paths" } | |||
c2rust-build-paths = { path = "../c2rust-build-paths" , version = "0.17.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually version
goes before path
and there's no space before the ,
.
👍
|
we now version all crates in lockstep as they are developed together, they will never depend on different versions of each other
7e4e433
to
7d2c381
Compare
This has been a long time coming, but we've now merged all the dep updates and gotten our release process in shape.