-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make import path consistent #1909
Conversation
Feel like I'm missing some context. What's the motivation here? What is going to stop it becoming "inconsistent" again straight away? |
@keithbro-imx |
@zaidarain1 the baseUrl is there because I want to do the test file separately in a different PR. they still use non-relative paths. also, that eslint rule is for absolute path tho. And I can't find a rule about "force relative path" in eslint. |
Running this rule with the above npm eslint-plugin-import packages errors out the imports for me as needed, but yeah the absolute path rule doesn't work. |
Summary
Some clean up on import paths.
This is not to make it consistent once for all but mainly for people that try out different approaches to build our sdk, especially when touching baseurl or removing tsconfig files, won't be bogged down by fixing all the imports.