feat: add session activity system #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cajames
force-pushed
the
kingmaking
branch
6 times, most recently
from
1951d4e to
41119f7
Compare
Jon-Alonso
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
I think so for SDK versions. But it's being phased out by the new tracking system. We'll eventually remove it completely.
There was a problem hiding this comment.
This was already removed by myself here 😄
This was approved on the basis that there are no references to it internally anymore and no one had used it in our team
There was a problem hiding this comment.
Ah awesome, removing it then.
cajames
force-pushed
the
kingmaking
branch
2 times, most recently
from
5feed74 to
b0e2882
Compare
nattb8
previously approved these changes
Jun 24, 2024
Jon-Alonso
previously approved these changes
Jun 24, 2024
Jon-Alonso
previously approved these changes
Jun 24, 2024
nattb8
previously approved these changes
Jun 24, 2024
zaidarain1
previously approved these changes
Jun 24, 2024
pano-skylakis
previously approved these changes
Jun 24, 2024
cajames
dismissed stale reviews from pano-skylakis, zaidarain1, nattb8, and Jon-Alonso
via
25070bf
Jon-Alonso
approved these changes
Jun 24, 2024
Comment on lines
+118
to
+121
| passportEventEmitter.on( | ||
| PassportEvents.ACCOUNTS_REQUESTED, | ||
| trackSessionActivity, | ||
| ); |
There was a problem hiding this comment.
This should probably be executed in the constructor of Passport.ts where we initialise the passportEventEmitter
haydenfowler
approved these changes
Jun 25, 2024
cajames
force-pushed
the
kingmaking
branch
2 times, most recently
from
a450a22 to
7f4e825
Compare
CodeSchwert
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please prefix this PR's title with:
breaking-change:if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:,fix:,refactor:,docs:, orchore:.Summary
Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?