New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix development-environment to work for Windows #1791

Merged

ljharb merged 2 commits into import-js:master from manuth:windows-fix

Jun 2, 2020

Contributor

manuth commented May 31, 2020 •

edited

Loading

~~Babel~~ nyc caused some errors on its currently installed version as seen in the AppVeyor history logs.
Some key modules of the development-environment have been updated:

nyc ("on the fly"-update in AppVeyor-script)
~~babel-modules~~
~~mocha~~

Though, applying this PR won't cause any issues when using with older versions of nodeJS (unless babel is configured correctly (see below)), after applying this PR, a nodeJS >=8 is required to develop this project.
As mentioned this should have no impact to the usage of the module, but to the development of the module which then will be performed with more modern module-versions.

~~To ensure, the built module also works for NodeJS argon, setting this option (targets.node) to the appropriate version-number might be necessary.~~

This PR fixes #1780 and fixes #1781


          [Tests] Add lodash.isarray to deps as temporary fix

1760b89

coveralls commented May 31, 2020 •

edited

Loading

Coverage remained the same at 97.737% when pulling 6dd28ea on manuth:windows-fix into 1737429 on benmosher:master.

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

5 similar comments

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

coveralls commented May 31, 2020

Coverage increased (+0.5%) to 98.247% when pulling dcbc648 on manuth:windows-fix into eb2b7ea on benmosher:master.

Contributor Author

manuth commented May 31, 2020 •

edited

Loading

@ljharb All's set up now, the tests for Windows as well as the tests for WSL run flawlessly now.
Only the coveralls command at the very end doesn't seem to work.
Probably you want to remove this from appveyor as there is a separate coverage/coveralls check anyway

~~Though I'll try to update coveralls to the most recent version and look whether this fixes the error.~~

Nvm cat doesn't exist on windows - I'll install a cross-platform replacement as a dependency.


          [Tests] fix coverage script for windows; tweak appveyor

6dd28ea

ljharb requested changes

View reviewed changes

package.json Outdated Show resolved Hide resolved

Contributor Author

manuth commented Jun 1, 2020

@ljharb alright I'm done here, too.
Would be awesome if you could merge this PR before #1792, so that I can rebase and refractor #1792 accordingly.

ljharb approved these changes

View reviewed changes

ljharb merged commit 6dd28ea into import-js:master

manuth deleted the windows-fix branch

June 4, 2020 12:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet