Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add badges to field template #7312

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Mar 14, 2024

Resolves GIVE-353

Description

This pull request adds some badges to the EventTickets template. The Sold Out badge appears on each line for tickets when none are available. The ENDED badge is displayed in the header once the event end date has passed. Under these conditions, no tickets are shown for sale.

Affects

EventTickets template

Visuals

CleanShot 2024-03-14 at 20 38 22
CleanShot 2024-03-14 at 20 29 25

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski requested a review from jdghinson March 15, 2024 00:02
@pauloiankoski
Copy link
Contributor Author

@jdghinson Could you review this?

Copy link
Contributor

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@pauloiankoski pauloiankoski requested a review from kjohnson March 25, 2024 21:18
@pauloiankoski pauloiankoski requested a review from kjohnson March 26, 2024 19:24
@pauloiankoski pauloiankoski merged commit 20b5483 into epic/event-tickets-follow-up-GIVE-371 Mar 27, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the feature/sold-out-message-GIVE-353 branch March 27, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants