-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add badges to field template #7312
Merged
pauloiankoski
merged 9 commits into
epic/event-tickets-follow-up-GIVE-371
from
feature/sold-out-message-GIVE-353
Mar 27, 2024
Merged
Feature: add badges to field template #7312
pauloiankoski
merged 9 commits into
epic/event-tickets-follow-up-GIVE-371
from
feature/sold-out-message-GIVE-353
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jdghinson Could you review this? |
jdghinson
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
kjohnson
reviewed
Mar 26, 2024
tests/Unit/EventTickets/Actions/ConvertEventTicketsBlockToFieldsApiTest.php
Outdated
Show resolved
Hide resolved
kjohnson
approved these changes
Mar 27, 2024
pauloiankoski
merged commit Mar 27, 2024
20b5483
into
epic/event-tickets-follow-up-GIVE-371
20 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-353
Description
This pull request adds some badges to the EventTickets template. The Sold Out badge appears on each line for tickets when none are available. The ENDED badge is displayed in the header once the event end date has passed. Under these conditions, no tickets are shown for sale.
Affects
EventTickets template
Visuals
Pre-review Checklist
@unreleased
tags included in DocBlocks